fix: record the real exit code from the PowerShell prompt hook

[guan4tou2]

What

hooks/shell-hook.ps1: the prompt function read $LASTEXITCODE into a variable before reading $?. $? describes only the previous statement, so by then it described that assignment and was always $true. Every failing PowerShell command was recorded as exit_code: 0.

The fix is to read $? first (the two lines swap, plus a comment saying why).

How it was found

Not by a test. I ran a packaged Windows build against an isolated profile and drove the hook in a real PowerShell: cmd /c exit 3 was recorded with exit_code: 0. Confirmed in isolation on both Windows PowerShell 5.1 and pwsh 7 — the shipped order gives success=True, the swapped order gives success=False.

Test

test/powershell-hook-exit-code.test.ts starts an interactive PowerShell (pwsh and Windows PowerShell, whichever exist; nothing is declared if neither does), dot-sources the hook with a temp USERPROFILE, feeds commands on stdin, and reads the events the hook spools to ~/.redlog/pending (no RedLog is running, so there is no api-port). It checks:

• a failing native command is recorded with its own code, a success as 0
• a failing cmdlet is recorded non-zero
• a native failure is not carried into the next successful command

All three fail on the old order (verified by running them before the fix), and all six (3 × 2 shells) pass after.

Checks

typecheck, verify:specs, verify:architecture, verify:i18n, npm test (343 files / 3503 tests passed, 33 skipped) — all green locally on Windows.

Not covered

• CI is ubuntu-only and I have not seen this test run there. If pwsh is not on the runner the suite declares nothing rather than failing, so on CI it may be a no-op; the Windows run above is what exercised it.
• Behaviour inside the built-in terminal's own PowerShell is the same hook; I did not add a separate check for it.

Refs #226

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8e58e154-f209-48d9-9a01-e3a3b8360a30

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}