Repository navigation
ci: install the NSIS build on a clean Windows runner and smoke-test it - #334
Merged
Merged
Conversation
Adds a manual / path-triggered workflow that packages the NSIS installer, checks the runner has no RedLog on it, silently installs, checks the Uninstall entry and both shortcuts, launches the app on the runner's own profile, runs the packaged-app smoke spec against the installed exe, then uninstalls and checks the entry, shortcuts and exe are gone. Refs #226 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…s for Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A
windows-latestworkflow,windows-install-smoke.yml, for the first-install-on-a-clean-machine check that could not be done locally (no Sandbox/Hyper-V here).workflow_dispatch, pluspull_requestlimited to the paths that can change its result (the workflow, the smoke spec,electron-builder.yml,shell-hook.ps1), so it does not run on every PR.Steps: build →
electron-builder --win nsis→verify:package-resources→ assert the runner has no RedLog (registry,~/.redlog,%APPDATA%\RedLog, install dir) → silent install → assert one Uninstall entry and both shortcuts pointing at the installed exe → launch on the runner's own profile and wait for/api/health→ rune2e/packaged-smoke.spec.tsagainst the installed exe (mitmproxy installed so the HTTP step runs; no WSL distro on the runner, so that step is skipped) → silent uninstall → assert entry, shortcuts and exe are gone, and report anything left in the install dir (fail only past 20 files).Also updates the "does not exercise" comment in the smoke spec to point here.
Verification
The workflow itself has not run yet when this is opened — it runs on this PR because the workflow file is one of its triggers; the result is in the checks below. Locally:
appId, so the real RedLog on that machine was untouched). One thing that run taught: the Uninstall entry'sDisplayNameisRedLog 0.18.0, version included, so the workflow matches^RedLog( |$)rather thanRedLog.npm test: 342 of 343 files passed; the one failure,test/shell-payload-fast.test.ts, gotWsl/Service/0x8007274c(a timeout starting the WSL service) frombashinstead of script output, and passes alone (154/154). That is a local WSL start-up timeout, not a code path this change touches.Refs #226
🤖 Generated with Claude Code