Repository navigation
fix(ci): publish with npm and retry existing release tags - #30
Merged
Merged
Conversation
Member
Author
|
@codex review the full current PR diff. Focus on correctness, lifecycle and concurrency, state isolation, compatibility, retry and failure paths, and regression risks. Report all P0/P1 findings found in this pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.2.12 release failed before publishing: pnpm 10.15.1 forwards
--no-git-checksto npm, and the current npm CLI rejects it withEUNKNOWNCONFIG.Use
npm publishdirectly for the dry run and release. Keep pnpm for installation and builds and retain OIDC authentication. This follows the npm trusted publishing workflow.Add a manual workflow entry point that checks out an existing tag so a failed npm publish can be retried without moving that tag or bumping another version. Manual retries skip GitHub release generation, and automatic and manual runs share the same per-tag concurrency group.
Validation:
pnpm exec eslint .github/workflows/publish.yml: passed.git diff --check: passed.