Repository navigation
feat(agent): friction-ladder plan steering + install gate - #26
Merged
Merged
Conversation
Reorients the propose skills toward "default to nothing, climb a friction ladder reluctantly" — Linux gaming is stable now and most games, even old ones, run on stock Proton. Changes are skill-only (plus two CLI wrinkles found while dogfooding AC Revelations on Deck). Skills: - funfa/SKILL.md: add the friction ladder (rung 0 nothing/stock Proton -> 1 env var -> 2 in-Steam Proton version -> 3 GE/installs) and a categorize-the-issue step where category predicts the expected rung; tighten PHASE 0 to require a same-game (appid/slug) match so an unrelated prior plan no longer mislabels the new one as "revisiting". - game-research/SKILL.md: add umu-protonfixes as the maintained anchor source; prune obsolete vars (PROTON_NO_ESYNC/FSYNC, DXVK_ASYNC, PROTON_USE_WINED3D); prefer official Valve Proton over GE; add the install gate (GE is rare-but-legitimate, must justify which Valve versions were checked and why they fail) plus native-dead->workaround and Deck-as-fixed-hardware weighting. - plan/SKILL.md: inline provenance (confirmed-date/Proton/Deck) on high-tier recs, order by friction, demote the GE example to a last-resort and require a Notes line clearing the install gate. CLI fixes (found dogfooding): - core/review-plan.ts: under --bypass-confirms, skip the framed review copy and footer so the plan renders once (the caller prints the clean pasteable markdown); interactive review/paste-back unchanged. Verified end-to-end via the codex path with FUNFA_FAKE_HARDWARE against AC Revelations (201870): fresh-plan labelling correct, single render, and GE recommendations now carry an explicit Valve-ladder justification. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reorients funfa's propose skills around a friction ladder: default to nothing, climb reluctantly, and only install software when the evidence genuinely demands it. The driving insight (from dogfooding an AC Revelations Deck replay) is that Linux gaming is stable now — most games, even old ones, run on stock Proton — so funfa's value is the rare nitpick fix on old titles, delivered as the lowest-friction change that works.
Skill-only behavior changes, plus two CLI wrinkles caught while testing.
Why
48190) mislabeled a new AC Revelations plan as "revisiting".Changes
funfa/SKILL.mdgame-research/SKILL.mdPROTON_NO_ESYNC/FSYNC,DXVK_ASYNC,PROTON_USE_WINED3D) — each var earns its place against stock Proton.plan/SKILL.md(confirmed <date> on <Proton>, Deck/desktop)on high-tier recs, ordered by friction.## Notesline clearing the install gate.core/review-plan.ts(CLI fix)--bypass-confirms, skip the framed review copy + footer so the plan renders once (the caller prints the clean pasteable markdown). Interactive review/paste-back is unchanged. New test locks in the no-print behavior.Testing
bun test(apps/cli): 91 pass / 0 fail, including the--compilesmoke test; typecheck clean.FUNFA_FAKE_HARDWARE(Steam Deck profile) against AC Revelations (201870): fresh-plan labelling correct, single render, and GE recommendations now carry an explicit Valve-ladder justification in Notes.Reviewer notes
hardware/game-research/planbodies (prompt.ts), so these edits are exercised on both the API-key and codex paths;prompt.test.ts's byte-identical loop-body assertion still holds sincefunfa/SKILL.mdis the sharedLOOP_BODY.plan.ts+ propose loop) and expanding thefetch-pageallowlist for umu's web DB / SteamDeckHQ. umu-protonfixes' GitHub repo is already reachable, so no allowlist change was needed for this PR.🤖 Generated with Claude Code