fix(overhead): suppress zero combined floater as noise#2271
Closed
3vcloud wants to merge 1 commit into
Closed
Conversation
When combining overhead numbers, a damage hit cancelled out by a heal (or vice versa) sums to zero and shows a meaningless "0" floater. Block the combined message when the total is zero for damage/heal/energy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When combining overhead numbers (the Combine floating numbers above character setting), a damage hit cancelled out by a heal — or overkill adjustments — can sum to 0, leaving a meaningless
0floater above the agent. As Jon put it, "showing zero on the damage monitor is just extra noise."This blocks the combined message when the total comes to zero for damage/heal/energy numbers (
h0004 != 2, so XP/faction gain floaters are unaffected). The already-rendered floater was destroyed during the combine step, so blocking the new one leaves nothing on screen.🤖 Generated with Claude Code