Feature/agt 002 commission calculation#46
Draft
ester-bloch wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
@claude please review my PR deeply. point at all problems you can find. |
…ers, ports, vessels, and voyages; add email existence check in agent creation
Owner
|
@ester-bloch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: feature/AGT-002-Commission-Calculation
Implemented commission-per-agent report for completed voyages.
What this PR adds
Implements the commission‑per‑agent report for completed voyages as specified in AGT‑002.
When a voyage reaches
COMPLETEDstatus, clients can now call:and receive a breakdown of each agent’s delivered orders, their total value and the commission earned, plus a grand total.
Key behaviors & business rules
FreightOrders with status DELIVERED are considered.finalPriceagent.commissionPercent / 100 × totalOrderValueWhat changed
AgentCommissionResponseandVoyageCommissionReportResponse.findByVoyageIdAndStatus(Long, OrderStatus)method.VoyageService.calculateCommissions(Long)method performs validation, querying, grouping, calculation and builds the response.VoyageController.VoyageCommissionTestcovers happy path, stats assertions, and edge/error cases (non‑completed voyage, missing voyage, mixed agent types, excluded orders).Testing
./mvnw testpasses – all existing and new tests are green.Notes
fromEntity()design pattern.@Transactional(readOnly = true).This PR completes the backend implementation described in
docs/AGT-002-DESIGN.mdand is ready for review.Closes AGT-002