Skip to content

Fix provider reconciler update loop #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruibaby merged 1 commit into from
Jul 20, 2026
+17 −2
Merged

Fix provider reconciler update loop #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/src/main/java/run/halo/aifoundation/provider/AiProviderReconciler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ public Result reconcile(Request request) {
}
return;
}
addFinalizers(provider.getMetadata(), Set.of(FINALIZER_NAME));
client.update(provider);
if (addFinalizers(provider.getMetadata(), Set.of(FINALIZER_NAME))) {
client.update(provider);
}
});
return Result.doNotRetry();
}
Expand Down
14 changes: 14 additions & 0 deletions app/src/test/java/run/halo/aifoundation/provider/AiProviderReconcilerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,20 @@ void reconcile_existingProvider_addsFinalizer() {
.contains(AiProviderReconciler.FINALIZER_NAME);
}

@Test
void reconcile_existingProviderWithFinalizer_doesNotUpdate() {
var provider = provider("openai-prod");
provider.getMetadata().setFinalizers(Set.of(AiProviderReconciler.FINALIZER_NAME));

when(client.fetch(AiProvider.class, "openai-prod")).thenReturn(Optional.of(provider));

var result = reconciler.reconcile(new Reconciler.Request("openai-prod"));

assertThat(result.reEnqueue()).isFalse();
verify(client, never()).delete(any(AiModel.class));
verify(client, never()).update(any());
}

@Test
void reconcile_providerNotFound_returnsDoNotRetry() {
when(client.fetch(AiProvider.class, "missing")).thenReturn(Optional.empty());
Expand Down