Skip to content

Use Halo HTTP security utilities for external fetches#146

Merged
ruibaby merged 1 commit into
mainfrom
codex/use-halo-http-security-utils
Jun 22, 2026
Merged

Use Halo HTTP security utilities for external fetches#146
ruibaby merged 1 commit into
mainfrom
codex/use-halo-http-security-utils

Conversation

@ruibaby

@ruibaby ruibaby commented Jun 14, 2026

Copy link
Copy Markdown
Member

Summary

  • Upgrade the plugin to depend on Halo 2.25 and require Halo >=2.25.0 at runtime.
  • Refactor external URL fetching to use Halos HttpSecurityUtils.secureHttpClient() and maxResponseSizeFilter(long).
  • Remove plugin-local SSRF URL validation and redirect helper code.
  • Replace implementation-detail tests with behavior-level coverage for link detail, RSS, and verification fetch behavior.

Why

Halo 2.25 exposes the HTTP security utilities through the plugin API, so the plugin can reuse Halos SSRF-safe HTTP client instead of maintaining duplicate address validation and socket handling logic.

Validation

  • ./gradlew test
  • ./gradlew build
  • openspec validate use-halo-http-security-utils --strict
  • git diff --check

@ruibaby
ruibaby marked this pull request as ready for review June 18, 2026 10:08
@ruibaby
ruibaby merged commit 8ec9bef into main Jun 22, 2026
1 check passed
@ruibaby
ruibaby deleted the codex/use-halo-http-security-utils branch June 22, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant