-
Notifications
You must be signed in to change notification settings - Fork 13
Rework usePermissions for compatibility with Directus 11 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you so much! This is a bit funny, since I'm the one of the people who implemented permissions in v11 and completely forgot about this little extension... The only problem I see is that it copied code verbatim from the Directus repository which is licensed under BSL and can't be easily relicensed for this repo I'm afraid. I will think of a solution for that. Maybe this is the push we need to make the composables available as part of the extensions SDK 🤔 |
|
Hmm, that is quite a problem. I know a lot of extension developers do that, just because the internals aren't exposed, but I'm not exactly sure how to go about avoiding that for this extension. (As Might be something worth clarifying with the core team? |
|
Came across this PR while looking up the error after updating to Directus 11. Will fork your PR for now until the license issue is resolved. But wanted to leave a message to say thanks for both the extension from Hannes and for you taking time to fix the issue :) |
|
Hi! Any updates on this? I am not sure if I should use the extension or look for alternatives (are there any?) |
|
Hi! Are there any updates on this? Thanks! |
|
Hi, is there any progress with this issue? It seems official implementation of this extension directly to Directus never happened, right? What is the best way how to fix it now? Do a fork and fix it by this? Thanks |
|
Heya, does anyone know what work needs to be done to this PR? I don't mind having a go. Also I assume there are some other extensions that needed similar changes and can be referenced? Or perhaps this feature is coming to directus natively soon? <3 |
The
usePermissionscomposable was completely overhauled for Directus 11, causing this extension to crash with an unexpected error on Directus 11 when used by non-Admin users.This PR does a preliminary job of porting over the
usePermissionschanges todirectus-extension-inline-form-interface. It hasn't been fully tested in all situations, but it does resolve the original crash when rendering the interface.