Replace harmony-one/bls fork with official herumi/bls-eth-go-binary - #313
Merged
Conversation
…armony dependency - Update harmony to v1.10.3-0.20260728072432-2e5db93591ed (post-PR#5086 dev branch) - Replace `github.com/harmony-one/bls/ffi/go/bls` import with `github.com/harmony-one/harmony/crypto/bls/core` in pkg/keys/bls.go, cmd/subcommands/staking.go, cmd/subcommands/utility.go - Update ethereum replace directive to v1.11.2 (required by new harmony) - Move IntrinsicGas call from harmony/core to harmony/core/vm and add isEIP3860 param in staking.go, ethtransfer.go, transfer.go - Update signer/core imports to signer/core/apitypes in pkg/governance/eip712.go and types.go - Run go mod tidy; herumi/bls-eth-go-binary v1.37.0 now replaces harmony-one/bls
Copilot
AI
changed the title
feat: replace harmony-one/bls with herumi/bls-eth-go-binary (mirror harmony PR#5086)
feat: replace harmony-one/bls fork with official herumi/bls-eth-go-binary
Jul 29, 2026
Copilot created this pull request from a session on behalf of
Frozen
July 29, 2026 20:25
View session
Frozen
marked this pull request as ready for review
July 29, 2026 21:02
Frozen
approved these changes
Aug 1, 2026
mur-me
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors harmony-one/harmony#5086 — drops the Harmony BLS fork in favor of the official Herumi package, and updates the harmony dependency to pick up those changes.
Dependency updates
github.com/harmony-one/harmony→v1.10.3-0.20260728072432-2e5db93591ed(dev, post-#5086)github.com/harmony-one/blsremoved;github.com/herumi/bls-eth-go-binary v1.37.0added (indirect via harmony)replace github.com/ethereum/go-ethereumbumpedv1.9.9→v1.11.2Code fixes required by updated dependencies
BLS import path (
pkg/keys/bls.go,cmd/subcommands/staking.go,cmd/subcommands/utility.go):IntrinsicGasrelocated and gained a parameter (staking.go,ethtransfer.go,transfer.go):EIP-712 types moved (
pkg/governance/eip712.go,pkg/governance/types.go):