Skip to content

Replace harmony-one/bls fork with official herumi/bls-eth-go-binary - #313

Merged
mur-me merged 2 commits into
masterfrom
copilot/update-dependencies-and-code
Aug 4, 2026
Merged

Replace harmony-one/bls fork with official herumi/bls-eth-go-binary#313
mur-me merged 2 commits into
masterfrom
copilot/update-dependencies-and-code

Conversation

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Mirrors harmony-one/harmony#5086 — drops the Harmony BLS fork in favor of the official Herumi package, and updates the harmony dependency to pick up those changes.

Dependency updates

  • github.com/harmony-one/harmonyv1.10.3-0.20260728072432-2e5db93591ed (dev, post-#5086)
  • github.com/harmony-one/bls removed; github.com/herumi/bls-eth-go-binary v1.37.0 added (indirect via harmony)
  • replace github.com/ethereum/go-ethereum bumped v1.9.9v1.11.2

Code fixes required by updated dependencies

BLS import path (pkg/keys/bls.go, cmd/subcommands/staking.go, cmd/subcommands/utility.go):

// before
bls_core "github.com/harmony-one/bls/ffi/go/bls"
// after
bls_core "github.com/harmony-one/harmony/crypto/bls/core"

IntrinsicGas relocated and gained a parameter (staking.go, ethtransfer.go, transfer.go):

// before
core.IntrinsicGas(data, false, true, true, isCreateValidator)
// after — package is now core/vm; new isEIP3860 bool at end
vm.IntrinsicGas(data, false, true, true, isCreateValidator, false)

EIP-712 types moved (pkg/governance/eip712.go, pkg/governance/types.go):

// before
"github.com/ethereum/go-ethereum/signer/core"
// after
"github.com/ethereum/go-ethereum/signer/core/apitypes"

…armony dependency

- Update harmony to v1.10.3-0.20260728072432-2e5db93591ed (post-PR#5086 dev branch)
- Replace `github.com/harmony-one/bls/ffi/go/bls` import with `github.com/harmony-one/harmony/crypto/bls/core` in pkg/keys/bls.go, cmd/subcommands/staking.go, cmd/subcommands/utility.go
- Update ethereum replace directive to v1.11.2 (required by new harmony)
- Move IntrinsicGas call from harmony/core to harmony/core/vm and add isEIP3860 param in staking.go, ethtransfer.go, transfer.go
- Update signer/core imports to signer/core/apitypes in pkg/governance/eip712.go and types.go
- Run go mod tidy; herumi/bls-eth-go-binary v1.37.0 now replaces harmony-one/bls
Copilot AI changed the title feat: replace harmony-one/bls with herumi/bls-eth-go-binary (mirror harmony PR#5086) feat: replace harmony-one/bls fork with official herumi/bls-eth-go-binary Jul 29, 2026
Copilot AI requested a review from Frozen July 29, 2026 20:25
@Frozen Frozen changed the title feat: replace harmony-one/bls fork with official herumi/bls-eth-go-binary Replace harmony-one/bls fork with official herumi/bls-eth-go-binary Jul 29, 2026
@Frozen
Frozen marked this pull request as ready for review July 29, 2026 21:02
@mur-me
mur-me requested review from GheisMohammadi and mur-me August 4, 2026 10:43
@mur-me
mur-me merged commit 810ebaf into master Aug 4, 2026
1 check passed
@mur-me
mur-me deleted the copilot/update-dependencies-and-code branch August 4, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants