Simplify Leader Quorum Calculations for Commit and Prepare Phases - #4813
Closed
GheisMohammadi wants to merge 6 commits into
Closed
Simplify Leader Quorum Calculations for Commit and Prepare Phases#4813GheisMohammadi wants to merge 6 commits into
GheisMohammadi wants to merge 6 commits into
Conversation
Contributor
|
are streamsync manager code intended to be in as well ? |
Collaborator
Author
No, it only moves SafeMap to common folder to be able to be used everywhere |
sophoah
approved these changes
Jan 24, 2025
Contributor
|
cc @Frozen |
Contributor
|
@Frozen thanks for review/approval |
Contributor
|
@GheisMohammadi please fix conflict |
GheisMohammadi
force-pushed
the
refactor/quorom
branch
from
February 20, 2025 11:12
efd5191 to
17595fd
Compare
Contributor
|
@GheisMohammadi please fix the travis CI run |
GheisMohammadi
force-pushed
the
refactor/quorom
branch
from
July 16, 2025 22:00
17595fd to
ddda021
Compare
GheisMohammadi
force-pushed
the
refactor/quorom
branch
4 times, most recently
from
July 18, 2025 14:02
7755aa9 to
064fb0e
Compare
GheisMohammadi
force-pushed
the
refactor/quorom
branch
from
August 3, 2026 11:33
064fb0e to
79f50ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the leader quorum calculation process for the commit and prepare phases by leveraging the State structure to store the last quorum-achieved block. Previously, the quorum status was checked dynamically, which could lead to inaccuracies under certain conditions. By using a state-based approach, the process becomes more efficient and reliable, ensuring better consistency in quorum handling.