Repository navigation
Include <cstddef> so GCC 11 can see size_t and ptrdiff_t. - #153
Merged
Merged
Conversation
GCC 11 does not inject those names from <vector> or <cstdint>, so the Vulkan build fails on that compiler. CI uses GCC 13 and does not catch it. Co-authored-by: Cursor <cursoragent@cursor.com>
harry7557558
approved these changes
Oct 7, 2026
harry7557558
left a comment
harry7557558
left a comment
Owner
There was a problem hiding this comment.
Looks good to me. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 11 does not inject global
size_torptrdiff_tfrom<vector>or<cstdint>, so this tree fails to build with that compiler (seen with g++ 11.5.0).Add
#include <cstddef>at the unqualified uses. Upstream CI runs onubuntu-24.04, whose default g++ is GCC 13, and does not catch this. The extra include does not change what GCC 13 already compiles.No GPU changes.
Test plan
bash build_develop.bash -DSS_BACKEND=vulkanwith GCC 11