reduce error report for non-error#638
Open
hermanbanken wants to merge 2 commits intohashicorp:mainfrom
Open
Conversation
|
|
Author
|
Any update? |
tgross
approved these changes
Mar 20, 2026
Member
tgross
left a comment
tgross
left a comment
There was a problem hiding this comment.
Sorry about the delayed review @hermanbanken. I've rebased on main and pushed a minor change to use errors.Is over an equality check (because that's more robust against someone wrapping the error later). I've also added a "fixes" link to #637 in the PR description, as you're not the only person who's hit this. 😁
LGTM but now that I've touched it I'll need to grab someone else for review. Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were worried about "failed to take snapshot" only to discover the real underlying error was "nothing new to snapshot". Guess it is better to not report that as an error.
Fixes: #637