Skip to content

H-5768: Quick Simulation in Edit Mode, and disable Simulate temporarily #8195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kube wants to merge 41 commits into
base: main
Choose a base branch
from
Open

H-5768: Quick Simulation in Edit Mode, and disable Simulate temporarily #8195

kube wants to merge 41 commits into from

Conversation

@kube
Copy link
Collaborator

@kube kube commented Dec 17, 2025 •
edited by CiaranMn
Loading

🌟 What is the purpose of this PR?

  • Allow for Quick Simulation directly from Edit mode.
    • Disable Simulate Tab for now
  • Enhancement and tweaks on Toolbar
  • Make all Panels (Left/Right/Bottom) share the same component
  • Rename DiagnosticsPanel to BottomPanel
    • Expose three tabs in BottomPanel:
      • Diagnostics
      • Global Parameters (will move in next PR, back to LeftPanel)
      • Simulation Settings (Computation + Parameters values)

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

  • Global Parameters is moved in BottomPanel but should be in LeftPanel (model objects)

🐾 Next steps

  • Create PanelView component (name subject to change) to simplify creation of subviews/tabs in Panels
  • Bring back Global Parameters to LeftPanel
  • Add Simulation Timeline in BottomPanel
  • Add Simulation Logs in BottomPanel

🛡 What tests cover this?

  • No tests at the moment as we still need to define a testing strategy for the UI
    • (Simulation features are still tested as unit tests)

❓ How to test this?

  1. Use latest Petrinaut deploy

@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team labels Dec 17, 2025
This was referenced Dec 17, 2025
Merged
Merged
@kube Graphite App
Copy link
Collaborator Author

kube commented Dec 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kube kube changed the title Everything always available in BottomBar H-5768: Quick Simulation in Edit Mode, and disable Simulate temporarily Dec 17, 2025
@kube kube changed the base branch from cf/h-5850-fix-pandacss-config-and-usage-in-petrinaut to graphite-base/8195 December 17, 2025 23:05
@kube kube force-pushed the cf/h-5768-integrate-quick-simulation-in-edit-mode branch from ae0b9a1 to 1d58d6c Compare December 17, 2025 23:05
@kube kube force-pushed the graphite-base/8195 branch from 2f6ebba to 33209de Compare December 17, 2025 23:05
@kube kube changed the base branch from graphite-base/8195 to cf/h-5850-fix-pandacss-config-and-usage-in-petrinaut December 17, 2025 23:05
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 17, 2025
View reviewed changes
@kube kube changed the base branch from cf/h-5850-fix-pandacss-config-and-usage-in-petrinaut to graphite-base/8195 December 19, 2025 09:39
@kube kube force-pushed the cf/h-5768-integrate-quick-simulation-in-edit-mode branch from 38a85b3 to 99b5eb3 Compare December 19, 2025 09:40
@kube kube force-pushed the graphite-base/8195 branch from 33209de to e26ecc9 Compare December 19, 2025 09:40
@kube kube changed the base branch from graphite-base/8195 to cf/h-5850-fix-pandacss-config-and-usage-in-petrinaut December 19, 2025 09:40
@kube kube force-pushed the cf/h-5850-fix-pandacss-config-and-usage-in-petrinaut branch from e26ecc9 to 97f0212 Compare December 19, 2025 10:37
@kube kube force-pushed the cf/h-5768-integrate-quick-simulation-in-edit-mode branch from 99b5eb3 to ec63ab3 Compare December 19, 2025 11:30
kube added 24 commits January 2, 2026 18:46
@kube
Move activeBottomPanel to EditorStore
a2501ff
@kube
Rename DiagnosticsPanel to BottomPanel
3c3e221
@kube
Use Play/Pause/Stop icons
866408c
@kube
Open Diagnostics when clicking on Run Simulation when errors disable it
4c509a1
@kube
Remove tooltip from Global Parameters panel, just show text
068778d
@kube
Cleaner BottomPanel
0b60acc
@kube
Remove Simulation State from Simulation Settings
1e0858a
@kube
BottomPanel styles
c4b6619
@kube
Add close button to BottomPanel
b4ccb94
@kube
Diagnostics Indicator opens Diagnostics in BottomPanel, with Tooltip
2dff2de
@kube
Add Toggle Panel button in BottomBar
d9aa09a
@kube
Hide Place/Transition buttons in BottomBar when Simulation is running
7963943
@kube
SDCPNView readonly when Simulation is running
51e084d
@kube
Make Token Types, Differential Equations and Global Parameters readon…
0fa8f29 
…ly while Simulation is running
@kube
Make Diagnostics expanded by default
c466316
@kube
Toolbar refinement + updates from demo review
8947f36
@kube
Adjust bezelWidth for current BottomBar height
612615e
@kube
Swap Parameters and Computation sections
b9b4530
@kube
Add tooltip on Time Step
14eb381
@kube
Format
f86ebfe
@kube
Remove dependency of SimulationProvider on EditorContext and reorder …
19021ee 
…Content order
@kube
Add useIsReadOnly hook
8e08ac6
@kube
Review: remove comment
18166fc
@kube
Remove globalMode check from TransitionProperties
5b09620
@kube kube force-pushed the cf/h-5768-integrate-quick-simulation-in-edit-mode branch from 96c2265 to 5b09620 Compare January 2, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@CiaranMn CiaranMn CiaranMn left review comments

+1 more reviewer

@semgrep-code-hashintel semgrep-code-hashintel[bot] semgrep-code-hashintel[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@kube kube

Labels

area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kube @CiaranMn