Ensure same supported_groups before/after HRR - #525
Closed
vdukhovni wants to merge 1 commit into
Closed
Conversation
As required by RFC8446 Section 4.1.2
| -- RFC 8446 Sec 4.1.4: the selected_group MUST be in supported_groups | ||
| -- and MUST NOT already have been offered in the initial key_share. | ||
| | selectedGroup `elem` groupsSupported | ||
| , selectedGroup `notElem` groupsSelected -> do |
Collaborator
There was a problem hiding this comment.
I would like to use && instead of , here.
I will take care of this by myself.
kazu-yamamoto
self-requested a review
April 15, 2026 02:09
kazu-yamamoto
added a commit
to kazu-yamamoto/hs-tls
that referenced
this pull request
Apr 15, 2026
Collaborator
|
Rebased and merged. |
Collaborator
Author
Many thanks for adopting and releasing the fix promptly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As required by RFC8446 Section 4.1.2
Fixes: #524