Add enable_cbc_ciphers flag - #526
Merged
Merged
Conversation
Collaborator
Author
|
There should probably be at least some tests that use the flag and the ciphers, unless it is best to just drop the flag, and leave the decision of whether to support these ciphers to each application. |
Collaborator
|
How about removing the flag/ |
Collaborator
|
@vdukhovni Gentle ping. |
This reintroduces some of the "safer" CBC ciphers. Applications still have to choose to use these, they are not included in any of the stock ciphersuite lists. In the SMTP ecosystem, where CBC ciphers don't present the sort of risks that motivate their deprecation in HTTPS, some systems are still CBC-only, and CBC ciphers are still required to achieve interoperability.
vdukhovni
force-pushed
the
enable-cbc-flag
branch
from
April 28, 2026 08:39
a080924 to
2f6bf3e
Compare
kazu-yamamoto
self-requested a review
April 28, 2026 10:31
Collaborator
|
Merged. |
Collaborator
|
v2.4.2 has been released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag makes it possible to include some of the "safer" CBC ciphers in the build. Applications still have to choose to use these, they are not included in any of the stock ciphersuite lists.
In the SMTP ecosystem, where CBC ciphers don't present the sort of risks that motivate their deprecation in HTTPS, some systems are still CBC-only, and CBC ciphers are still required to achieve interoperability.
[ Given that these have to be chosen explicitly by the application,
perhaps the flag is overkill, and they could just be made available
unconditionally??? The flag is however sufficient for my purposes. ]