Improve find methods schemas to convert to valid types#119
Merged
Conversation
Signed-off-by: Nikolay Marchuk <nikolay.marchuk@hardcoreeng.com>
There was a problem hiding this comment.
Pull Request Overview
This PR improves type safety in validation schemas by ensuring that validated parameters are properly converted to their expected branded types. The changes introduce branded string types for various ID types and convert unknown parameter types to properly validated types before passing them to provider methods.
- Introduced
brandedStringhelper function to transform plain strings into branded types - Changed parameter types from specific types to
unknownin find methods to ensure runtime validation - Added proper type casting for NotificationType using
z.nativeEnum
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/server/src/middleware/validate.ts | Updated validation schemas to use branded types and modified find methods to accept unknown params that are validated and cast to proper types |
| packages/server/src/tests/middleware/validate.test.ts | Updated test to validate date string coercion by passing raw string date and expecting coerced Date object |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Nikolay Marchuk <nikolay.marchuk@hardcoreeng.com>
kristina-fefelova
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.