Fix Facebook video analytics ID resolution

[heshanlk]

What does this PR do?

Why?

How to test

Checklist

• Tests pass (pytest)
• Lint passes (ruff check . and ruff format --check .)
• Documentation updated (if applicable)

[chatgpt-codex-connector]

💡 Codex Review

brightbean-studio/providers/facebook.py

Lines 583 to 586 in f3fec70

	except Exception as exc:
	errors_by_post_id[post_id] = str(exc)
	logger.warning("Facebook post insights failed at %s: %s", endpoint, exc)
	continue

Let transient insight failures abort the snapshot

When the insights request fails for a transient reason that is not an APIError (for example _request raises RateLimitError on a 429 or resp.json() raises), this catch-all converts the failure into empty insight data and get_post_metrics still returns a successful PostMetrics. The analytics task then writes at least zero-valued derived rows such as reactions/engagement and resets the post cadence instead of skipping the snapshot and retrying later, so temporary Facebook outages can pollute daily analytics.

---

brightbean-studio/providers/facebook.py

Lines 615 to 617 in f3fec70

	except Exception as exc:
	last_error = exc
	break

Let transient field fetch failures abort the sync

This new broad handler also swallows non-API failures from the post fields request, such as rate limits, connection errors, or malformed JSON, and returns {} as if the engagement fields were simply unavailable. If the insights call succeeds afterward, the sync records a partial snapshot without comments/shares or the object-level reaction fallback and advances the cadence; unexpected request failures should propagate to _sync_post_metrics so the failed fetch is skipped rather than saved as incomplete analytics.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".