Skip to content

2.1.2 Insight info back press #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zafrani wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

2.1.2 Insight info back press #1310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/is/hello/sense/flows/home/ui/fragments/InsightsFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ public final void onInsightClicked(@NonNull final InsightsAdapter.InsightViewHol
return;
}
final InsightInfoFragment infoFragment = InsightInfoFragment.newInstance(insight, getResources());
infoFragment.show(fragment.getChildFragmentManager(),
infoFragment.show(fragment.getFragmentManager(),
R.id.view_home_container,
InsightInfoFragment.TAG);
this.selectedInsightHolder = viewHolder;
Expand Down
6 changes: 0 additions & 6 deletions app/src/main/java/is/hello/sense/ui/dialogs/InsightInfoFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ public class InsightInfoFragment extends AnimatedInjectionFragment

@UsedInTransition
private View rootView;
@UsedInTransition

@simonc312 simonc312 Apr 25, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does removing the fill view do? Does it affect the enter / exit animation for insight info?

@zafrani zafrani Apr 25, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes an unused variable.

private View fillView;

@UsedInTransition
private ExtendedScrollView scrollView;
Expand Down Expand Up @@ -136,7 +134,6 @@ public static InsightInfoFragment newInstance(@NonNull final Insight insight,
@Override
public void onCreate(final Bundle savedInstanceState) {
super.onCreate(savedInstanceState);

final Bundle arguments = getArguments();
final String category = arguments.getString(ARG_CATEGORY);
if (category != null) {
Expand All @@ -163,7 +160,6 @@ public void onCreate(final Bundle savedInstanceState) {
@Override
public View onCreateView(final LayoutInflater inflater, final ViewGroup container, final Bundle savedInstanceState) {
this.rootView = inflater.inflate(R.layout.fragment_insight_info, container, false);
this.fillView = rootView.findViewById(R.id.fragment_insight_info_fill);
this.progress = (ProgressBar) rootView.findViewById(R.id.fragment_insight_info_progress);
this.illustrationImage =
(ParallaxImageView) rootView.findViewById(R.id.fragment_insight_info_illustration);
Expand Down Expand Up @@ -313,7 +309,6 @@ protected void onEnterAnimatorEnd() {
@Override
protected void onExitAnimatorEnd() {
this.rootView = null;
this.fillView = null;
this.scrollView = null;
this.topShadow = null;
this.bottomShadow = null;
Expand Down Expand Up @@ -556,7 +551,6 @@ public void onBitmapFailed() {
}

//endregion

private void shareInsightSuccess(@NonNull final ShareUrl shareUrl) {
final Share.Text text = Share.text(shareUrl.getUrlForSharing(getActivity()));
if (category != null) {
Expand Down