fix(agent): generic fix for duplicate detection and IO stats for extra filesystems - #2119
Open
SteffenV wants to merge 2 commits into
Open
fix(agent): generic fix for duplicate detection and IO stats for extra filesystems#2119SteffenV wants to merge 2 commits into
SteffenV wants to merge 2 commits into
Conversation
Previously, extra filesystems were incorrectly identified as duplicates when their disk usage matched the root filesystem inside the container. This fix compares the actual block device names (e.g. /dev/nvme0n1p6) instead of relying on disk usage, which is unreliable in containerized environments where overlayfs is used. Fixes henrygd#2103
- Generic device detection for extra filesystems - IO statistics are correctly reported - All extra filesystems are properly recognized - Prevents false duplicate detection of filesystems on different block devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two related issues with extra filesystems:
Duplicate detection: Previously, extra filesystems were incorrectly identified as duplicates when their disk usage matched the root filesystem. This fix compares actual block device names instead of disk usage.
IO statistics: Extra filesystems used their folder names (e.g. DATA, HOME) for diskstats lookup, causing 'Device not found' warnings. This fix maps folder names to their real block devices using partition information.
Changes:
__syntax for custom display namesTested with:
Fixes both the duplicate detection issue and the device not found warnings for extra filesystems.