Conversation
Nekaze
commented
Feb 17, 2026
| config = { "FOO" => "bar" } | ||
| @hatchet_app ||= begin | ||
| app = Hatchet::Runner.new("default_ruby", buildpacks: ["heroku/ruby"]) | ||
| app = Hatchet::Runner.new("default_ruby", buildpacks: ["heroku/ruby"], config: config) |
Contributor
Author
There was a problem hiding this comment.
I had to add this to fix the test where config vars are checked. The config vars were returning empty and causing the test to fail.
By adding this, we force the hatchet app to have some config vars that can be checked in the test.
I am not sure how this worked before, but my guess is that it used DATABASE_URL or other configs that may take some time to appear on the app, depending on the provisioning time.
Nekaze
commented
Feb 17, 2026
| - name: "Set bundler path" | ||
| run: bundle config set path 'vendor/bundle' | ||
| - name: "Install dependencies" | ||
| run: bundle install --jobs=4 --retry=3 --path vendor/bundle |
Contributor
Author
There was a problem hiding this comment.
This is no longer supported in Ruby 4.0. The fix is to set the path with bundle config set path 'vendor/bundle'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the ruby versions used in the CI to the currently supported Ruby versions https://www.ruby-lang.org/en/downloads/branches/
This PR also:
FOO=barset on creation