Skip to content

feat: increase default poll interval for long running actions #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jooola merged 2 commits into from
Mar 18, 2026
+24 −1
Merged

feat: increase default poll interval for long running actions #1364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e2ccf2
feat: increase poll interval for long running actions
jooola Mar 17, 2026
f758f38
Start the exponential backoff from the beginning
jooola Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion internal/state/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"io"
"os"
"strings"
"time"

"github.com/hetznercloud/cli/internal/hcapi2"
"github.com/hetznercloud/cli/internal/state/config"
Expand Down Expand Up @@ -124,11 +125,33 @@ func (c *state) newClient() (hcapi2.Client, error) {
return nil, err
}

if pollInterval > 0 {
if pollInterval > 0 && config.OptionPollInterval.Changed(c.config) {
opts = append(opts, hcloud.WithPollOpts(hcloud.PollOpts{
BackoffFunc: hcloud.ConstantBackoff(pollInterval),
}))
} else {
opts = append(opts, hcloud.WithPollOpts(hcloud.PollOpts{
BackoffFunc: customPollBackoffFunc(),
}))
}

return hcapi2.NewClient(opts...), nil
}

func customPollBackoffFunc() hcloud.BackoffFunc {
constantFunc := hcloud.ConstantBackoff(500 * time.Millisecond)

exponentialFunc := hcloud.ExponentialBackoffWithOpts(hcloud.ExponentialBackoffOpts{
Base: 500 * time.Millisecond,
Multiplier: 1.5,
Cap: 2500 * time.Millisecond,
})

// Poll every 500ms for the first 5s, then use an exponential backoff capped to 2500ms
return func(retries int) time.Duration {
if retries < 10 {
return constantFunc(retries)
}
return exponentialFunc(retries - 10)
}
}
Loading