This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Include transitive_proto_paths in the call to protoc#211
Open
kerinin wants to merge 1 commit intohigherkindness:masterfrom
Open
Include transitive_proto_paths in the call to protoc#211kerinin wants to merge 1 commit intohigherkindness:masterfrom
kerinin wants to merge 1 commit intohigherkindness:masterfrom
Conversation
Proto rules that specify `strip_import_prefix` or `import_prefix` may have a different import path than their workspace-relative path, and so may not be visible on compile. This includes the transitive proto paths for a compile target to the ScalaPB compiler invocation ensuring that such targets can be compiled.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proto rules that specify
strip_import_prefixorimport_prefixmayhave a different import path than their workspace-relative path, and so
may not be visible on compile. This includes the transitive proto paths
for a compile target to the ScalaPB compiler invocation ensuring that
such targets can be compiled.