Update cpp dependency using latest Cython - #41
Open
daanknoope wants to merge 1 commit into
Open
daanknoope wants to merge 1 commit into
daanknoope wants to merge 1 commit into
Conversation
This was referenced Apr 16, 2023
|
This worked like a charm for me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
_mdlp.cpphas been generated using a version of Cython (0.27.2) which is not supported by Python > 3.6. (see: mcfletch/pyopengl#11).Since many users will be using a Python version greater than 3.6 (due to it being EOL), users that do not have Cython installed will get errors while installing this package (see: #34 (comment)).
To prevent this issue I have updated the precompiled
_mdlp.cpp, which should now work with Python>=3.7 (also tested with 3.11).