Repository navigation
feat(plugin): cover goroutine mode and exact replay for v0.2.0 - #586
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin's skill still says faultline v0.1.x cannot run goroutine code. This updates it for v0.2.0 and sets the plugin version to 0.2.0.
skills/faultline/SKILL.md: thedeterminism:line of a goroutine-mode report (exact or level 3), what a re-run that passed means for a best-effort seed, keeping-toolexec=faultline-toolexecin a replay and runningfaultline-toolexec preparewhen the build asks for it, writing a goroutine-mode test, and a new answer for a flaky test with no faultline test: say what the code must take as values (listener, dialer, filesystem) before faultline can run it.skills/faultline/rules.md: rules split into event mode and goroutine mode (p.Net,p.FS,p.Rand,p.Go,p.Do, no mutex across a blocking shim call, noos.Exit), goroutine-mode causes of a determinism failure and the toolexec message, and what faultline cannot do.skills/faultline/artifacts.md: theleakkind,determinism_level,goroutines.txt,toolexec-gaps.txt,stall.txtand the goroutine-mode record kinds.skills/replay/SKILL.md: a replay command with the wrapper, and a best-effort seed whose trace hash differs.agents/triage.md: coverage gaps in a determinism failure, and a directory with onlystall.txt.evals/flaky-test-without-faultline: the reply now passes when it says the replication code must take its listener and dialer as values (or be ported to the node API) and offers a faultline test; it fails when it says faultline cannot run goroutine code at all.How it was checked: every API, file name and message the skill names was checked against the code on main (
process.go,exact.go,report.go,watchdog.go,artifact/report.go,shims/), andtech-writing/lint.shis clean. The eval suite was not run for this change. The docs pages the skill links (docs/guides/goroutine-mode.md,docs/guides/exact-replay.md) come with the v0.2.0 docs PR, which merges first.