Repository navigation
build: require faultline v0.2.0 in the nested modules - #587
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runner/toolexec,shims/grpcsimandharness/etcdraftnow require faultline v0.2.0, which is tagged and on the module proxy. As in #286, thereplace github.com/hmdsefi/faultline => ../..lines stay, so the repository still builds the nested modules against the working tree. Each module rango get github.com/hmdsefi/faultline@v0.2.0andgo mod tidy; only the threerequirelines change, and nogo.sumchanges.This matters most for
runner/toolexec: itsschedpackage importsinternal/gosched, which faultline v0.1.2 does not have, so a user module that gotrunner/toolexecwith a v0.1.2 requirement could not build. The three nested modules are tagged v0.2.0 at this merge commit.