-
-
Notifications
You must be signed in to change notification settings - Fork 27
Add publish selector test and remove debug output #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hoc081098
wants to merge
1
commit into
publishWithSelector
Choose a base branch
from
codex/review-pr-and-provide-feedback
base: publishWithSelector
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
src/commonTest/kotlin/com/hoc081098/flowext/PublishWithSelectorTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| /* | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2021-2024 Petrus Nguyễn Thái Học | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
|
|
||
| package com.hoc081098.flowext | ||
|
|
||
| import com.hoc081098.flowext.utils.BaseTest | ||
| import kotlin.test.Test | ||
| import kotlin.test.assertEquals | ||
| import kotlinx.coroutines.ExperimentalCoroutinesApi | ||
| import kotlinx.coroutines.delay | ||
| import kotlinx.coroutines.flow.filter | ||
| import kotlinx.coroutines.flow.filterIsInstance | ||
| import kotlinx.coroutines.flow.flatMapMerge | ||
| import kotlinx.coroutines.flow.flow | ||
| import kotlinx.coroutines.flow.map | ||
| import kotlinx.coroutines.flow.merge | ||
| import kotlinx.coroutines.flow.take | ||
| import kotlinx.coroutines.flow.toList | ||
|
|
||
| @OptIn(FlowExtPreview::class, ExperimentalCoroutinesApi::class) | ||
| class PublishWithSelectorTest : BaseTest() { | ||
| @Test | ||
| fun publishDispatchesSelectedFlows() = runTest { | ||
| val result = | ||
| flow<Any?> { | ||
| delay(100) | ||
| emit(1) | ||
| delay(100) | ||
| emit(2) | ||
| delay(100) | ||
| emit(3) | ||
| delay(100) | ||
| emit("4") | ||
| } | ||
| .publish { | ||
| delay(100) | ||
|
|
||
| merge( | ||
| select { flow -> | ||
| delay(1) | ||
| val sharedFlow = flow.shareIn() | ||
|
|
||
| interval(0L, 100L) | ||
| .flatMapMerge { value -> | ||
| timer(value, 50L) | ||
| .withLatestFrom(sharedFlow) | ||
| .map { it to "shared" } | ||
| } | ||
| .takeUntil(sharedFlow.filter { it == 3 }) | ||
| }, | ||
| select { flow -> | ||
| flow | ||
| .filterIsInstance<Int>() | ||
| .filter { it % 2 == 0 } | ||
| .map { it to "even" } | ||
| .take(1) | ||
| }, | ||
| select { flow -> | ||
| flow | ||
| .filterIsInstance<Int>() | ||
| .filter { it % 2 != 0 } | ||
| .map { it to "odd" } | ||
| .take(1) | ||
| }, | ||
| select { flow -> | ||
| flow | ||
| .filterIsInstance<String>() | ||
| .map { it to "string" } | ||
| .take(1) | ||
| }, | ||
| ) | ||
| } | ||
| .toList() | ||
|
|
||
| assertEquals( | ||
| listOf(Pair(1, "odd"), Pair(2, "even"), Pair("4", "string")), | ||
| result, | ||
| ) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Expected list ignores shared selector emissions
This test merges four selectors, but the first selector (
interval(0L, 100L)…withLatestFrom(sharedFlow).takeUntil(sharedFlow.filter { it == 3 })) emits at least(1, "shared")and(2, "shared")before the shared flow reaches3. Because the assertion only includes theodd,even, andstringpairs, the collectedresultwill contain additional elements and the test will fail whenever it is run. Either include the shared selector’s outputs in the expected list or modify that selector so it deliberately produces no values.Useful? React with 👍 / 👎.