adding-and-retrieving-professional - #2
Open
hokka1do wants to merge 4 commits into
Open
Conversation
iChurinov
requested changes
Jul 28, 2022
| @Autowired | ||
| private ProfessionalRepository professionalRepository; | ||
|
|
||
| @GetMapping("/professional/get") |
Collaborator
There was a problem hiding this comment.
The resource path is not restful
https://stackoverflow.blog/2020/03/02/best-practices-for-rest-api-design/#h-use-nouns-instead-of-verbs-in-endpoint-paths
| SpringApplication.run(BookMeApplication.class, args); | ||
| } | ||
| @PostConstruct | ||
| private void initDb(){ |
Collaborator
There was a problem hiding this comment.
DB initialization should be done using sql resource files
| import java.util.NoSuchElementException; | ||
|
|
||
| @RestController | ||
| @RequestMapping("/api/professional") |
Collaborator
There was a problem hiding this comment.
Resource collection URL should be defined in the plural
|
|
||
| @GetMapping | ||
| public List<Professional> getAllProfessionals() { | ||
| return (List<Professional>) professionalRepository.findAll(); |
Collaborator
There was a problem hiding this comment.
Class casting is not needed
| @GetMapping("/id") | ||
| public ResponseEntity<Professional> findProfessionalById(@PathVariable(value = "id") Long professionalId) { | ||
| Professional professional = professionalRepository.findById(professionalId).orElseThrow(() -> | ||
| new NoSuchElementException(("Professional not available for Id :" + professionalId))); |
Collaborator
There was a problem hiding this comment.
Not bad. But does your application return a 404 error response in such a case?
| @@ -1 +1,20 @@ | |||
| spring.datasource.url=jdbc:h2:mem:professional-db | |||
Collaborator
There was a problem hiding this comment.
It is better to use application.yaml file format for properties
iChurinov
reviewed
Jul 28, 2022
| public class BookMeApplication { | ||
|
|
||
| @Autowired | ||
| private ProfessionalRepository professionalRepository; |
Collaborator
There was a problem hiding this comment.
Unnecessary , remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.