Skip to content

Add scene platform for Sunricher DALI integration #157808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
niracler wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Add scene platform for Sunricher DALI integration #157808

niracler wants to merge 9 commits into from
+574 −97

Conversation

@niracler
Copy link
Contributor

@niracler niracler commented Dec 3, 2025 •
edited
Loading

Breaking change

Proposed change

Add scene platform for Sunricher DALI integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description. maginawin/PySrDaliGateway@v0.16.2...v0.18.0

To help with the load of incoming pull requests:

@niracler
feat(sunricher_dali): add scene platform
a5c3559 
- Implement DaliCenterScene entity with activation support
- Add parallel discovery of devices and scenes using asyncio.gather
- Include entity ID mappings in scene attributes for related lights
- Add comprehensive test coverage with fixtures and snapshots
@niracler niracler marked this pull request as ready for review December 3, 2025 06:13
@niracler niracler marked this pull request as draft December 3, 2025 06:14
@niracler
feat(sunricher_dali): add scene platform
31443c6 
- Implement DaliCenterScene entity with activation support
- Add parallel discovery of devices and scenes using asyncio.gather
- Include entity ID mappings in scene attributes for related lights
- Add comprehensive test coverage with fixtures and snapshots
@niracler
add PARALLEL_UPDATES
d3a9379
@niracler niracler mentioned this pull request Dec 3, 2025
Open
8 tasks
@niracler
fix(sunricher_dali): remove debug logging and improve test coverage
8e971c9 
- Remove debug warning log in scene.py
- Fix test_scene_read_failure to properly test exception handling during setup
- Achieve 100% code coverage for scene platform
@niracler
refactor(sunricher_dali): optimize test structure
219901b 
- Unify test data with DEVICE_DATA constant
- Simplify mock device creation
- Merge redundant test cases (9 → 5)
- Maintain 100% test coverage
@niracler niracler marked this pull request as ready for review December 3, 2025 09:58
joostlek
joostlek requested changes Dec 3, 2025
View reviewed changes
@home-assistant
Copy link

home-assistant bot commented Dec 3, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 3, 2025 17:07
joostlek
joostlek reviewed Dec 4, 2025
View reviewed changes
@niracler
deps: update PySrDaliGateway to 0.18.0
1f9ea82
@niracler
refactor(sunricher_dali): extract DaliDeviceEntity class
323384c 
- Remove isinstance check from DaliCenterEntity
- Add DaliDeviceEntity for device-specific initialization
- Update DaliCenterLight to use new base class
@niracler niracler marked this pull request as ready for review December 5, 2025 01:33
@home-assistant home-assistant bot requested a review from joostlek December 5, 2025 01:33
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Dec 5, 2025

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joostlek joostlek Awaiting requested review from joostlek

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

by-code-owner cla-signed has-tests integration: sunricher_dali new-feature new-platform Quality Scale: bronze

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@niracler @joostlek