Skip to content

Conversation

@ThyMYthOS
Copy link
Contributor

@ThyMYthOS ThyMYthOS commented Dec 6, 2025

Breaking change

Remove deprecated import from stiebel_eltron component

Proposed change

Remove functionality that was marked as broken in 2025.11.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 6, 2025

Hey there @fucm, mind taking a look at this pull request as it has been labeled with an integration (stiebel_eltron) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of stiebel_eltron can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign stiebel_eltron Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated YAML configuration import functionality from the stiebel_eltron integration, which was scheduled for removal in version 2025.11. The changes remove the _async_import function that handled YAML-to-config-entry migration and several related imports.

Key changes:

  • Removed _async_import function that handled YAML configuration imports
  • Removed imports: SOURCE_IMPORT, FlowResultType, issue_registry, and typing.Any
  • Simplified async_setup to only return True since it no longer processes YAML configuration

@ThyMYthOS ThyMYthOS force-pushed the stiebel_obsolete branch 2 times, most recently from 0145f52 to 9874620 Compare December 6, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant