fix(serve-static): fix onFound timing #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usualoma
force-pushed
the
fix-on-found-timing
branch
from
d33e150 to
68a80cc
Compare
Member
Author
|
@yusukebe |
Member
|
Thank you! I've confirmed, and it works well. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #225
As mentioned in #225, I also believe the timing at which
onFoundis called inserveStaticofnode-serveris somewhat premature.In the hono core, it is called immediately before returning the response, so I think it should be aligned accordingly.
https://github.com/honojs/hono/blob/main/src/middleware/serve-static/index.ts#L117