Skip to content

CON-4646 Added pre-check to filter invalid values for the nfsResources parameter with appropriate error message #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yatish-Sriram wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

CON-4646 Added pre-check to filter invalid values for the nfsResources parameter with appropriate error message #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/driver/controller_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,10 @@ func (driver *Driver) createVolume(
filesystem = defaultFileSystem
log.Trace("Using default filesystem type: ", filesystem)
}
// Validate nfsResources value if present - provide a clear error for invalid values
if nfsResourcesVal, ok := createParameters[nfsResourcesKey]; ok && !strings.EqualFold(nfsResourcesVal, trueKey) {
return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("invalid value '%s' for StorageClass parameter %s, the only valid value is '%s'", nfsResourcesVal, nfsResourcesKey, trueKey))
}
if driver.IsSupportedMultiNodeAccessMode(volumeCapabilities) && !(driver.IsNFSResourceRequest(createParameters) || driver.IsFileRequest(createParameters)) {
return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("StorageClass parameter %s=%s is missing for creation of volumes with multi-node access for NFS or StorageClass parameter %s=%s is missing for creation of volumes with multi-node access File", nfsResourcesKey, trueKey, accessProtocolKey, nfsFileSystem))
}
Expand Down