Repository navigation
Recommended fix: bound retained triggering-user history reads - #326
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Agent review
No problems found in the four areas this agent checks.
Possible breaking changes
- ⚪
.github/workflows/quality.ymlChanges CI. Make sure the required checks still run and keep their names.
Checked 3 files at 0285ff5: skin scope, breaking changes, secrets and private paths, COMPONENTS.md reuse. Under the team rules (AGENTS.md), this counts as the non-author review for @defleur-agents once every 🔴 is fixed; a non-high-risk Recommended fix with a failing-first regression test needs no review. Reviewer: humanitylabs-org/wizard-ux/tools/pr-agent-review.mjs.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Agent review
No problems found in the four areas this agent checks.
Possible breaking changes
- ⚪
.github/workflows/quality.ymlChanges CI. Make sure the required checks still run and keep their names.
Checked 3 files at 607287e: skin scope, breaking changes, secrets and private paths, COMPONENTS.md reuse. Under the team rules (AGENTS.md), this counts as the non-author review for @defleur-agents once every 🔴 is fixed; a non-high-risk Recommended fix with a failing-first regression test needs no review. Reviewer: humanitylabs-org/wizard-ux/tools/pr-agent-review.mjs.
There was a problem hiding this comment.
Agent review
No problems found in the four areas this agent checks.
Possible breaking changes
- ⚪
.github/workflows/quality.ymlChanges CI. Make sure the required checks still run and keep their names.
Checked 3 files at 878aaea: skin scope, breaking changes, secrets and private paths, COMPONENTS.md reuse. Under the team rules (AGENTS.md), this counts as the non-author review for @defleur-agents once every 🔴 is fixed; a non-high-risk Recommended fix with a failing-first regression test needs no review. Reviewer: humanitylabs-org/wizard-ux/tools/pr-agent-review.mjs.
There was a problem hiding this comment.
Agent review
No problems found in the four areas this agent checks.
Possible breaking changes
- ⚪
.github/workflows/quality.ymlChanges CI. Make sure the required checks still run and keep their names.
Checked 4 files at 15bc8a2: skin scope, breaking changes, secrets and private paths, COMPONENTS.md reuse. Under the team rules (AGENTS.md), this counts as the non-author review for @defleur-agents once every 🔴 is fixed; a non-high-risk Recommended fix with a failing-first regression test needs no review. Reviewer: humanitylabs-org/wizard-ux/tools/pr-agent-review.mjs.
There was a problem hiding this comment.
Agent review
No problems found in the four areas this agent checks.
Possible breaking changes
- ⚪
.github/workflows/quality.ymlChanges CI. Make sure the required checks still run and keep their names.
Checked 4 files at b8273fc: skin scope, breaking changes, secrets and private paths, COMPONENTS.md reuse. Under the team rules (AGENTS.md), this counts as the non-author review for @defleur-agents once every 🔴 is fixed; a non-high-risk Recommended fix with a failing-first regression test needs no review. Reviewer: humanitylabs-org/wizard-ux/tools/pr-agent-review.mjs.
There was a problem hiding this comment.
Agent review
No problems found in the four areas this agent checks.
Possible breaking changes
- ⚪
.github/workflows/quality.ymlChanges CI. Make sure the required checks still run and keep their names.
Checked 4 files at 6b5497b: skin scope, breaking changes, secrets and private paths, COMPONENTS.md reuse. Under the team rules (AGENTS.md), this counts as the non-author review for @defleur-agents once every 🔴 is fixed; a non-high-risk Recommended fix with a failing-first regression test needs no review. Reviewer: humanitylabs-org/wizard-ux/tools/pr-agent-review.mjs.
What and why
Port live 165c2b0 plus affinity fixture corrections 57eeac7/85c3397 onto shared main, without the live version bump. Bound every retained active/inactive/NULL timestamp range with the existing session/active/timestamp index before selecting the triggering-user body. Preserve table ties, legacy views, compaction, rewound authority and next-connection changes.
Reuse:
Verified
node --check server/session-truth.mjs and git diff --check passed. CI explicitly executes the eight synthetic query-plan/oracle/affinity tests plus the normal regression suite. Exact-head results are pending, not claimed passed.
Not checked
Exact-head CI and independent last-push approval. Reconcile the small session-truth hunk with separate #300 when both merge. No production DB/home reads, deployment, restart or pointer change.
Links
Source backup/james-live-20261103; 165c2b0, 57eeac7 and 85c3397.
Exact-head verification update
At
607287e2, CI proves the frozen main module fails the two new indexed-range checks; this head passes the 7/7 triggering-user suite (the earlier body estimate of eight was incorrect). Full Quality passes (142 Vitest files / 1780 tests and separate suites). This is not merged: one APPROVED review plus non-last-push approval is required.Main-sync integration update
Merged shared main into this branch, preserving both this bounded-read regression and the model-lock regression from #320. Added the actual backend capability inventory row; no fabricated WizardApp dependency. Visual: none (backend-only). New exact-head CI is required before merge; no live deployment, restart or phone activation.