Fix: fe and clr not calculated if ae not included in intervals (#473)#474
Merged
billdenney merged 8 commits intohumanpred:mainfrom Dec 10, 2025
Merged
Conversation
13 tasks
Member
|
I like this simple fix. Can you please add a test for it with |
Member
|
When merged this will likely fix #376, too. |
3 tasks
Gero1999
changed the title
Contributor
Author
|
@billdenney I implemented the test and detected a similar problem for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #473
Just worthy to mention that the unit tests we do for
pk.calcfunction will never cover these cases. Maybe is worthy to consider doing at some point a test forpk.ncawith a dataset that contains all columns and a for-loop checking all parameters independently.