Fix a usability issue with Command - previous text gets in the way of subsequent invocations#136
Open
pokle wants to merge 1 commit intohunvreus:developmentfrom
Open
Fix a usability issue with Command - previous text gets in the way of subsequent invocations#136pokle wants to merge 1 commit intohunvreus:developmentfrom
pokle wants to merge 1 commit intohunvreus:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya,
This fixes a usability issue I noticed when opening the command dialog. If there's existing text from a previous use, that text gets in the way of entering new text. Users have to delete it first before entering new text.
The way other such components in the wild work is by selecting existing text so that users can type over if they prefer (or edit the existing text if they prefer). For example the MacOS Spotlight Search does this.
To test:
ojito select 'Search Emoji'), and hit ENTER