Feature: Add Full Component CSS Exports + Build Improvements#57
Closed
rrpadilla wants to merge 2 commits intohunvreus:developmentfrom
Closed
Feature: Add Full Component CSS Exports + Build Improvements#57rrpadilla wants to merge 2 commits intohunvreus:developmentfrom
rrpadilla wants to merge 2 commits intohunvreus:developmentfrom
Conversation
Author
|
@hunvreus What do think about this pr? |
Owner
|
Sure, I just need to find time to review this week. |
Author
|
@hunvreus did you have time to review this PR? |
|
+1 from me. Love this PR! |
|
+1 great idea |
|
bump |
Owner
|
@rrpadilla Would you be able to rework the PR to work with the latest version? Same work, just a few more files/blocks. I can do it myself but I'd like to still attribute the changes to you. |
Author
|
@hunvreus working on it. Submitting a PR in a few. |
Owner
|
Thanks! |
Author
|
Closing this in favor of #115. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No breaking changes — these files remain intact: (
basecoat.css,basecoat.cdn.css)Add Component-Level Style Exports
basecoat.all.cssandbase/base.cssto distbase/base.cssincludes the foundational styles:You can now import scoped styles like:
It is recommended to include the base file when adding individual components. This was added to the documentation.
The documentation has been updated. There is a new (Optional) Import specific components under installation instructions.
There is a new
basecoat.all.cssfile with all components listed. In the future we can update thebasecoat.cssto include this file@import "./basecoat.all.css";but I did not want to change the original files to avoid breaking changes.Resolves #54