fix dualshock 4 pairings #751
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 29, 2020 13:37
|
It's not your computer, I have the same issue. |
Collaborator
|
Hi @krokben , thanks for providing this fix. Please can you change the target branch to "dev". Meanwhile I change this PR to Draft. |
gen2thomas
added
the
maintainer wanted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pairings for my DualShock 4 controller were completely off on MacOS Catalina 10.15.4 so I fixed them by changing the IDs in
joystick_dualshock4.goand also adding two new eventTouchpadPressandTouchpadRelease. I am not sure if it's just my computer that registers the events of my DualShock controller differently or not, but these changes fixed it for my controller.