Skip to content

fix(batch): preserve failed and non-converged optimization outcomes - #80

Merged
hydrogen1222 merged 2 commits into
mainfrom
fix/aud-batch-outcome-contract-20261101
Nov 2, 2026
Merged

hydrogen1222 merged 2 commits into
mainfrom
fix/aud-batch-outcome-contract-20261101

Conversation

@hydrogen1222

Copy link
Copy Markdown
Owner

Tracking: #75 (AUD-BATCH-001); related to #78 (optimizer crash outcome).

Confirmed defect

BatchRunner._run_single() projected only energy/fmax/time from an optimization result, discarding converged, status, and error. run_from_files() then unconditionally reported success: true for every normally returned result. Thus an optimizer crash that retained partial results (fixed in #78) and an honest max_steps non-convergence could both appear as successful batch computations.

Changes

  • Classify the full runner result using the shared classify_result(..., calc_type="opt") outcome contract, and propagate status, converged, error, energy and timing.
  • Only completed counts as success; failed includes unsuccessful structures, with a separate not_converged subset so existing total = success + failed remains valid. Exceptions remain failed with tracebacks.
  • Add parameterized synthetic runner regression tests for converged, non-converged, returned optimizer crash, and escaping exception, including on-disk batch_summary.json.
  • Update EN/ZH batch docs. No inference or optimization algorithm changes.

Validation and constraints

The baseline/positive and negative cases are pinned by deterministic tests without downloading models. GitHub CI must pass before merging; source review alone is not a test run. No real GPU MLIP was executed. Requires independent code review against the current main.

DATA IMPACT

No scientific record was rewritten. Older batch_summary.json files produced before this fix may have false success: true entries; audit them against their per-structure mliport_results.json or run log rather than trusting the historical summary.

…D-BATCH-001)

Classify returned per-structure results through the shared outcome contract; record failure, non-convergence and partial evidence without marking a run successful. Add regression cases and bilingual docs.

DATA IMPACT: no existing scientific record rewritten; previously misleading batch summary statuses require interpretation against individual run artifacts.
DATA IMPACT: none; formatting only.
@hydrogen1222
hydrogen1222 marked this pull request as ready for review November 2, 2026 03:47
@hydrogen1222
hydrogen1222 merged commit 0d71f0a into main Nov 2, 2026
13 checks passed
@hydrogen1222
hydrogen1222 deleted the fix/aud-batch-outcome-contract-20261101 branch November 2, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant