Repository navigation
fix(batch): preserve failed and non-converged optimization outcomes - #80
Merged
Merged
Conversation
…D-BATCH-001) Classify returned per-structure results through the shared outcome contract; record failure, non-convergence and partial evidence without marking a run successful. Add regression cases and bilingual docs. DATA IMPACT: no existing scientific record rewritten; previously misleading batch summary statuses require interpretation against individual run artifacts.
DATA IMPACT: none; formatting only.
hydrogen1222
marked this pull request as ready for review
November 2, 2026 03:47
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking: #75 (AUD-BATCH-001); related to #78 (optimizer crash outcome).
Confirmed defect
BatchRunner._run_single()projected only energy/fmax/time from an optimization result, discardingconverged,status, anderror.run_from_files()then unconditionally reportedsuccess: truefor every normally returned result. Thus an optimizer crash that retained partial results (fixed in #78) and an honestmax_stepsnon-convergence could both appear as successful batch computations.Changes
classify_result(..., calc_type="opt")outcome contract, and propagatestatus,converged,error, energy and timing.completedcounts assuccess;failedincludes unsuccessful structures, with a separatenot_convergedsubset so existingtotal = success + failedremains valid. Exceptions remain failed with tracebacks.batch_summary.json.Validation and constraints
The baseline/positive and negative cases are pinned by deterministic tests without downloading models. GitHub CI must pass before merging; source review alone is not a test run. No real GPU MLIP was executed. Requires independent code review against the current
main.DATA IMPACT
No scientific record was rewritten. Older
batch_summary.jsonfiles produced before this fix may have falsesuccess: trueentries; audit them against their per-structuremliport_results.jsonor run log rather than trusting the historical summary.