Repository navigation
fix(nep): support GPUMD format_version 1 energy NEP including NEP89 - #90
Merged
Merged
Conversation
… families DATA IMPACT: no historical scientific record invalidated.
…mliport/calculators/nep_calc.py DATA IMPACT: no scientific record invalidated.
…mliport/gpumd/input.py DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
…y NEP4 DATA IMPACT: no scientific record invalidated.
DATA IMPACT: none; temporary diagnostic step.
DATA IMPACT: no scientific record invalidated.
…el provenance DATA IMPACT: no scientific record invalidated.
…el provenance DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
…flow DATA IMPACT: none.
DATA IMPACT: no historical artifact rewritten.
DATA IMPACT: no scientific record invalidated.
DATA IMPACT: no scientific record invalidated.
hydrogen1222
marked this pull request as ready for review
November 7, 2026 04:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking: #61; #75
Implement a shared, strict NEP header parser used by both Calorine and native GPUMD. Accept the new
nep 89 ...,format_version 1,model neplayout; preserve element order, energy_reference, cutoff (including per-type), ZBL and separate model-format/version identity in ASE metadata and native provenance. Explicitly reject temperature, qNEP, dipole, polarizability, spin and vdW model families rather than interpreting them as standard energy potentials. Keep legacy nep4 and nep4_zbl support.Adds isolated format tests. Note: headers are intentionally synthetic; real NEP89 GPUMD model inference remains unverified pending the user's local model and GPUMD binary.
DATA IMPACT: no historical scientific records invalidated; future provenance gains format details.