This repository was archived by the owner on Sep 5, 2026. It is now read-only.
ci: add lua-language-server type-check (non-blocking) - #11
Merged
Merged
Conversation
Add a `typecheck` job that runs `lua-language-server --check` over the Lua sources. lazydev only supplies type libraries inside Neovim, so the job reproduces that parity for standalone LuaLS: it restores plugins into the nvim-dev data dir (shared cache with `check`), then injects `workspace.library` = $VIMRUNTIME + the installed plugin `lua` dirs into a committed base config (.github/luarc.ci.json) written as the effective .luarc.json. `--check` exits non-zero on problems, so the exit code is the signal (this LuaLS version writes no check.json). checklevel is Warning. `undefined-field` is disabled for now: every current finding was a false positive from LuaSnip's incomplete field annotations (ls.text_node, etc.); the useful diagnostics (type mismatches, undefined-global, missing-parameter) stay on. The job is intentionally NOT in branch protection yet — informative while it stabilizes, to be promoted to a required check once trusted. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
typecheckCI job runninglua-language-server --checkover the Luasources, the deferred item from the keymap-util pass.
lazydev parity in CI
lazydev only supplies LuaLS type libraries inside Neovim. The job
reproduces that for standalone LuaLS:
nvim-devdatadir (shared cache key with
check).workspace.library=$VIMRUNTIME+ the installed pluginluadirs into a committed base (
.github/luarc.ci.json), written as theeffective
.luarc.json(LuaLS can't expand env vars, so paths areresolved at run time). The repo's own
.luarc.json(editor/lazydev) isleft untouched.
lua-language-server --check .— exits non-zero on problems (this versionwrites no check.json, so the exit code is the signal). Pinned to 3.18.2.
Settings
undefined-fielddisabled: every current finding (23, all inLuaSnip-related files) was a false positive from LuaSnip's incomplete field
annotations (
ls.text_node, …). The useful diagnostics — type mismatches,undefined-global, missing-parameter, etc. — stay on. Open to re-enabling
later with per-plugin typing.
Rollout
The job is not in branch protection yet (informative, can go red without
blocking merges). Promote it to a required check once trusted.
Verification
Reproduced locally with LuaLS 3.18.2-dev + the same library injection:
0 problems, exit 0. Before disabling
undefined-field: 23 problems in 6files, all LuaSnip interop.
🤖 Generated with Claude Code