-
Notifications
You must be signed in to change notification settings - Fork 65
[ENH] Sktime regression integration #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ENH] Sktime regression integration #209
Conversation
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failures are due to lack of isolation of the imports in get_test_params - have a look how this is solved for the time series classification case.
|
Hi @fkiraly !! Is it looks fine now ? |
SimonBlanke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already looks good! Please resolve the comments.
| dict | ||
| Additional metadata about the search. | ||
| """ | ||
| from sktime.classification.model_evaluation import evaluate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sktime.regression doesnot have evaluate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkiraly any comments ?
Summary
This PR adds integration for sktime time series regression, addressing . It introduces TSROptCV, enabling users to optimize sktime regressors using any Hyperactive optimizer (e.g., Random Search, Hill Climbing, Optuna TPE).
Key Changes
TSROptCVin_regression.py— a delegate regressor that wraps the Hyperactive optimization workflow.SktimeRegressionExperimentinsktime_regression.py— an adapter connecting sktime’sevaluate()function to Hyperactive’s experiment interface.TSROptCVin__init__.py.test_sktime_estimators.pyto ensure compatibility with the sktime estimator contract._BaseGFOadapterto exposebest_score_for consistency with other integrations.API Usage
Testing
Fixes
Fixes #196