fix: bold entry method label on entry method proposal (closes #1800)#2071
fix: bold entry method label on entry method proposal (closes #1800)#2071webguru-hypha wants to merge 1 commit intomainfrom
Conversation
WalkthroughA styling enhancement applied to the ProposalEntryInfo component that adds bold formatting to the entry method label by introducing the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #1800 Co-authored-by: webguru-hypha <webguru-hypha@users.noreply.github.com>
2863551 to
2e49284
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/epics/src/governance/components/proposal-entry-info.tsx (1)
9-9:⚠️ Potential issue | 🔴 CriticalReplace
anyingetEntryMethodLabelparameter with proper translator function type.
tProposalDetailsparameter is currently typed asany(line 9), but it's a translator function fromuseTranslations('ProposalDetails'). Type it asReturnType<typeof useTranslations>to maintain type safety.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/epics/src/governance/components/proposal-entry-info.tsx` at line 9, The parameter tProposalDetails in getEntryMethodLabel is typed as any; change its type to ReturnType<typeof useTranslations> to reflect that it is the translator returned by useTranslations('ProposalDetails'). Update the signature of getEntryMethodLabel (and any callers if needed) to use ReturnType<typeof useTranslations>, referencing the useTranslations symbol so TypeScript infers the correct translator function type for tProposalDetails.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/epics/src/governance/components/proposal-entry-info.tsx`:
- Line 9: The parameter tProposalDetails in getEntryMethodLabel is typed as any;
change its type to ReturnType<typeof useTranslations> to reflect that it is the
translator returned by useTranslations('ProposalDetails'). Update the signature
of getEntryMethodLabel (and any callers if needed) to use ReturnType<typeof
useTranslations>, referencing the useTranslations symbol so TypeScript infers
the correct translator function type for tProposalDetails.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 011c1ccc-2564-48ec-acf8-70ed448279d4
📒 Files selected for processing (1)
packages/epics/src/governance/components/proposal-entry-info.tsx
Summary
The "Entry Method" label on the proposal detail view for change-entry-method proposals was rendered with the same weight as body text. This adds
font-boldto the label inProposalEntryInfo, matching the emphasis used for other section titles in proposal detail (e.g. whitelist subsection headings).Testing
Closes #1800
Summary by CodeRabbit