Skip to content

fix: bold entry method label on entry method proposal (closes #1800)#2071

Open
webguru-hypha wants to merge 1 commit intomainfrom
cursor/issue-1800-resolution-f4ff
Open

fix: bold entry method label on entry method proposal (closes #1800)#2071
webguru-hypha wants to merge 1 commit intomainfrom
cursor/issue-1800-resolution-f4ff

Conversation

@webguru-hypha
Copy link
Copy Markdown
Contributor

@webguru-hypha webguru-hypha commented Mar 28, 2026

Summary

The "Entry Method" label on the proposal detail view for change-entry-method proposals was rendered with the same weight as body text. This adds font-bold to the label in ProposalEntryInfo, matching the emphasis used for other section titles in proposal detail (e.g. whitelist subsection headings).

Testing

  • Visual: open a proposal that includes entry method data and confirm the "Entry Method" label appears bold.

Closes #1800

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Style
    • Enhanced the visual prominence of the proposal entry method label by applying bold text styling.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2026

Walkthrough

A styling enhancement applied to the ProposalEntryInfo component that adds bold formatting to the entry method label by introducing the font-bold CSS class to the left label container element.

Changes

Cohort / File(s) Summary
UI Styling
packages/epics/src/governance/components/proposal-entry-info.tsx
Added font-bold class to the entry method label's left container for enhanced visual emphasis.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • DSanich
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title follows conventional commits format (fix: description) but lacks the required scope reference for the affected package or app. Update title to include scope: 'fix(epics): bold entry method label on entry method proposal (closes #1800)' to reference the affected package.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR successfully addresses issue #1800 by adding the font-bold class to the Entry Method label in ProposalEntryInfo, meeting the requirement for bolded text.
Out of Scope Changes check ✅ Passed The single file change is directly related to issue #1800 and focuses only on styling the Entry Method label without introducing unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/issue-1800-resolution-f4ff

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Closes #1800

Co-authored-by: webguru-hypha <webguru-hypha@users.noreply.github.com>
@alexprate alexprate force-pushed the cursor/issue-1800-resolution-f4ff branch from 2863551 to 2e49284 Compare March 29, 2026 15:18
@alexprate alexprate marked this pull request as ready for review March 29, 2026 15:18
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/epics/src/governance/components/proposal-entry-info.tsx (1)

9-9: ⚠️ Potential issue | 🔴 Critical

Replace any in getEntryMethodLabel parameter with proper translator function type.

tProposalDetails parameter is currently typed as any (line 9), but it's a translator function from useTranslations('ProposalDetails'). Type it as ReturnType<typeof useTranslations> to maintain type safety.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/epics/src/governance/components/proposal-entry-info.tsx` at line 9,
The parameter tProposalDetails in getEntryMethodLabel is typed as any; change
its type to ReturnType<typeof useTranslations> to reflect that it is the
translator returned by useTranslations('ProposalDetails'). Update the signature
of getEntryMethodLabel (and any callers if needed) to use ReturnType<typeof
useTranslations>, referencing the useTranslations symbol so TypeScript infers
the correct translator function type for tProposalDetails.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@packages/epics/src/governance/components/proposal-entry-info.tsx`:
- Line 9: The parameter tProposalDetails in getEntryMethodLabel is typed as any;
change its type to ReturnType<typeof useTranslations> to reflect that it is the
translator returned by useTranslations('ProposalDetails'). Update the signature
of getEntryMethodLabel (and any callers if needed) to use ReturnType<typeof
useTranslations>, referencing the useTranslations symbol so TypeScript infers
the correct translator function type for tProposalDetails.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 011c1ccc-2564-48ec-acf8-70ed448279d4

📥 Commits

Reviewing files that changed from the base of the PR and between 5fe3fdb and 2e49284.

📒 Files selected for processing (1)
  • packages/epics/src/governance/components/proposal-entry-info.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entry method title should be bolded

2 participants