Skip to content

Add libc++ < 20 fallback for floating-point scale value validation #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vaxerski merged 1 commit into from
May 7, 2026
Merged

Add libc++ < 20 fallback for floating-point scale value validation #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,24 @@ int main(int argc, char** argv, char** envp) {
}
case 's': {
float value;
#if defined(_LIBCPP_VERSION) && _LIBCPP_VERSION < 200000
try {
size_t pos;
value = std::stof(optarg, &pos);
if (pos != strlen(optarg))
throw std::invalid_argument("");
} catch (...) {
std::cerr << "Invalid scale value: " << optarg << "\n";
exit(1);
}
#else
auto result = std::from_chars(optarg, optarg + strlen(optarg), value);

if (result.ec != std::errc() || result.ptr != optarg + strlen(optarg)) {
std::cerr << "Invalid scale value: " << optarg << "\n";
exit(1);
}
#endif

if (value < 1.0f || value > 10.0f) {
std::cerr << "Scale must be between 1 and 10!\n";
Expand Down
Loading