chore: make llvm-ar and llvm-objcopy commands use version 16 explicitly#3
Open
novusnota wants to merge 1 commit intoi582:pmakhnev/actonfrom
Open
chore: make llvm-ar and llvm-objcopy commands use version 16 explicitly#3novusnota wants to merge 1 commit intoi582:pmakhnev/actonfrom
novusnota wants to merge 1 commit intoi582:pmakhnev/actonfrom
Conversation
On some machines, `llvm-ar` does not exist even after running the llvm/clang installation script. It can be fixed with `update-alternatives` on Ubuntu or a symbolic link, but since we demand both LLVM and Clang to be of version 16, let's just explicitly require the proper `llvm-ar-16` binary and be done with it. Plus, let's not use absolute system paths and instead invoke `llvm-objcopy-16` directly.
novusnota
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some machines,
llvm-ardoes not exist even after running the llvm/clang installation script. It can be fixed withupdate-alternativeson Ubuntu or a symbolic link, but since we demand both LLVM and Clang to be of version 16, let's just explicitly require the properllvm-ar-16binary and be done with it.Plus, let's not use absolute system paths and instead invoke
llvm-objcopy-16directly.cc @i582 @Danil42Russia