Update GammaGammaSolutionFinder input collection parameters to match …#143
Open
ggrenier wants to merge 1 commit into
Open
Update GammaGammaSolutionFinder input collection parameters to match …#143ggrenier wants to merge 1 commit into
ggrenier wants to merge 1 commit into
Conversation
…Marlin Processor Code
Contributor
|
Thanks. This looks straight forward. I will add some CI for this and future PRs and then merge afterwards, unless you want to add more changes to this. |
Contributor
|
Apologies this took longer than anticipated, but there is CI now. Can you rebase on top of the latest master branch (or merge that into this one?). I have added some CI in #145 which should also confirm that this works as expected. |
tmadlener
reviewed
Aug 2, 2024
| <parameter name="InputParticleCollectionName1" value="GammaGammaCandidatePi0s" /> | ||
| <parameter name="InputParticleCollectionName2" value="GammaGammaCandidateEtas" /> | ||
| <parameter name="InputParticleCollectionName3" value="GammaGammaCandidateEtaPrimes" /> | ||
| <parameter name="gammagammaCandidateCollections" > |
Contributor
There was a problem hiding this comment.
Is gammagammaCandidateCollections the correct capitalization or the one from the Gaudi configuration with GammaGammaCandidateCollections?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Marlin Processor Code
BEGINRELEASENOTES
The GammaGammaSolutionFinder Marlin Processor code has been updated years ago to change the way inpute collection names are provided, see https://github.com/iLCSoft/MarlinReco/blob/master/Analysis/GammaGammaSolutionFinder/src/GammaGammaSolutionFinder.cc
ENDRELEASENOTES