Skip to content

Update CMake configuration to adopt a more modern style#5

Merged
tmadlener merged 7 commits into
iLCSoft:masterfrom
tmadlener:udpate-cmake
Oct 2, 2025
Merged

Update CMake configuration to adopt a more modern style#5
tmadlener merged 7 commits into
iLCSoft:masterfrom
tmadlener:udpate-cmake

Conversation

@tmadlener
Copy link
Copy Markdown
Contributor

@tmadlener tmadlener commented Oct 1, 2025

BEGINRELEASENOTES

  • Adopt cmake configuration to use the target based style of configuring
  • Raise the minimum version of cmake to 3.23
    • Keep existing behavior by enabling cmake policy CMP0033
  • Fix dependencies to rely on LCIO instead of Marlin (since Marlin is not truly a dependency, but LCIO is).
  • Make ROOT a required dependency since building without ROOT is not possible
  • Export targets for downstream consumption with pure cmake functionality. The exported target is MarlinKinfit::MarlinKinfit.

ENDRELEASENOTES

Instead of blanket linking against things
Needs to be addressed in a general overhaul
Without ROOT FourVector is not available and MarlinKinfit doesn't build.
Hence, we promote this to a non-optional dependency and remove the
include guards around it.
@tmadlener
Copy link
Copy Markdown
Contributor Author

I have tested this locally and the stack builds without changes. Usage of the target in downstream packages can start with the next release most likely.

@tmadlener tmadlener closed this Oct 2, 2025
@tmadlener tmadlener reopened this Oct 2, 2025
Remove the dependency on ilcutil functionality to track dependencies,
etc. Keep MarlinKinfit_LIBRARIES populated for backwards compatibility.
@tmadlener
Copy link
Copy Markdown
Contributor Author

release based CI is failing because the necessary ilcutil PR is not yet there.

@tmadlener tmadlener merged commit 5ca8e1d into iLCSoft:master Oct 2, 2025
3 of 4 checks passed
@tmadlener tmadlener deleted the udpate-cmake branch October 2, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant