Update CMake configuration to adopt a more modern style#5
Merged
Conversation
Instead of blanket linking against things
Needs to be addressed in a general overhaul
Without ROOT FourVector is not available and MarlinKinfit doesn't build. Hence, we promote this to a non-optional dependency and remove the include guards around it.
Contributor
Author
|
I have tested this locally and the stack builds without changes. Usage of the target in downstream packages can start with the next release most likely. |
Remove the dependency on ilcutil functionality to track dependencies, etc. Keep MarlinKinfit_LIBRARIES populated for backwards compatibility.
fbf2b82 to
45594d5
Compare
Contributor
Author
|
release based CI is failing because the necessary ilcutil PR is not yet there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
MarlinKinfit::MarlinKinfit.ENDRELEASENOTES