Skip to content

Tof analysis#141

Merged
tmadlener merged 12 commits into
iLCSoft:masterfrom
dudarboh:TOFAnalysis
Nov 10, 2025
Merged

Tof analysis#141
tmadlener merged 12 commits into
iLCSoft:masterfrom
dudarboh:TOFAnalysis

Conversation

@dudarboh

@dudarboh dudarboh commented Sep 30, 2024

Copy link
Copy Markdown
Member

BEGINRELEASENOTES

  • Adding time-of-flight particle identification analysis codes from Bohdan Dudar's PhD studies.

ENDRELEASENOTES

TODO

  • Run Marlin and ensure that it successfully runs.
  • Check if the Track length reconstruction in Tracking is the latest and greatest

@dudarboh dudarboh changed the title Tof analysis [WIP] Tof analysis Sep 30, 2024
@dudarboh

Copy link
Copy Markdown
Member Author

Sorry, I only noticed #140 ...
Do we want to keep the warnings for now?

@tmadlener

Copy link
Copy Markdown
Contributor

I can lift the commit with the "external warnings" into a separate PR. Thanks for taking care of it, I haven't gotten around to it yet.

@tmadlener

Copy link
Copy Markdown
Contributor

Warnings of #140 have been fixed in #142. A simple rebase here should do the rest.

@dudarboh dudarboh changed the title [WIP] Tof analysis Tof analysis Oct 1, 2024
@tmadlener

Copy link
Copy Markdown
Contributor

I think the analysis and plotting code would be better suited for ILDPerformance, where a TimeOfFlight subfolder already exists. Is it somewhat easy to split that off from here?

@dudarboh

dudarboh commented Oct 2, 2024

Copy link
Copy Markdown
Member Author

I liked the idea that one can find all the codes related to my study in one place given only one link.
But I see that it is a bit inconsistent with other parts of the software...

I can move the analysis folder with all Python scripts to the ILDPerformance with a note that they are meant to be used with a ROOT file produced from this processor in MarlinReco.
Do you have any opinion on how to organise the old code from ILDPerformance/TimeOfFlight? Should everything else be put into the old folder? Maybe you have better ideas for a better name. Or is it so obsolete that it can be safely removed?

./src/BohdanDrawing is meant to be used inside the Marlin processor for debugging, so I would say it is better to stay here as I do not think it is very useful separately... Creating a separate processor just for these functions only is unnecessary, imho.

@tmadlener tmadlener merged commit 46c72c8 into iLCSoft:master Nov 10, 2025
6 checks passed
@dudarboh dudarboh deleted the TOFAnalysis branch November 10, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants