Fix clang warnings.#55
Merged
Merged
Conversation
tmadlener
force-pushed
the
clang-20260406
branch
from
63634af to
bdf3028
Compare
tmadlener
reviewed
Apr 7, 2026
| bool alreadyCollected = false; | ||
|
|
||
| float ESumCalorimeterHits = 0.0; // accumulated energy of calorimeter hits where the track contributes | ||
| //float ESumCalorimeterHits = 0.0; // accumulated energy of calorimeter hits where the track contributes |
Contributor
There was a problem hiding this comment.
I would have a preference for simply removing these instead of leaving them here as comment.
Contributor
Author
There was a problem hiding this comment.
I didn't remove those entirely because they're referenced later on in code that's already commented out (generally in debugging printouts.)
So this is just making things consistent.
If you prefer, we can just remove the commented-out debugging code as well and thus all traces of these identifiers.
Contributor
There was a problem hiding this comment.
Fair enough. Let's leave them there then and not rock the boat too much ;)
|
|
||
|
|
||
| int count_lines=0; | ||
| //int count_lines=0; |
|
|
||
| bool endOfFile = false; | ||
| unsigned int numberOfLines = 0; | ||
| //unsigned int numberOfLines = 0; |
Unused variables/members. Precision loss in int->float conversion.
tmadlener
force-pushed
the
clang-20260406
branch
from
bdf3028 to
5f54ca9
Compare
tmadlener
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused variables/members.
Precision loss in int->float conversion.
BEGINRELEASENOTES
ENDRELEASENOTES