Skip to content

[measure-tools] Adopt generated Units.* identifiers and phenomenon-aware bearing fallback #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hl662 wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[measure-tools] Adopt generated Units.* identifiers and phenomenon-aware bearing fallback #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17c2172
[measure-tools] Bump @itwin/core-* peer + dev pins to 5.10.0-dev.22
hl662 May 28, 2026
fe977fa
[measure-tools] Replace magic unit strings with generated Units.* ide…
hl662 May 28, 2026
3bbbf05
[measure-tools] Make bearing fallback FormatProps phenomenon-aware
hl662 May 28, 2026
598e501
[measure-tools] Address review feedback on bearing fallback
hl662 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions apps/test-viewer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,23 @@
"type": "module",
"private": true,
"dependencies": {
"@itwin/appui-abstract": "^5.9.2",
"@itwin/appui-abstract": "^5.10.0-dev.22",
"@itwin/appui-react": "^5.30.0",
"@itwin/browser-authorization": "^2.0.2",
"@itwin/components-react": "^5.30.0",
"@itwin/core-bentley": "^5.9.2",
"@itwin/core-common": "^5.9.2",
"@itwin/core-frontend": "^5.9.2",
"@itwin/core-geometry": "^5.9.2",
"@itwin/core-i18n": "^5.9.2",
"@itwin/core-markup": "^5.9.2",
"@itwin/core-orbitgt": "^5.9.2",
"@itwin/core-quantity": "^5.9.2",
"@itwin/core-bentley": "^5.10.0-dev.22",
"@itwin/core-common": "^5.10.0-dev.22",
"@itwin/core-frontend": "^5.10.0-dev.22",
"@itwin/core-geometry": "^5.10.0-dev.22",
"@itwin/core-i18n": "^5.10.0-dev.22",
"@itwin/core-markup": "^5.10.0-dev.22",
"@itwin/core-orbitgt": "^5.10.0-dev.22",
"@itwin/core-quantity": "^5.10.0-dev.22",
"@itwin/core-react": "^5.30.0",
"@itwin/ec3-widget-react": "workspace:*",
"@itwin/ecschema-metadata": "^5.9.2",
"@itwin/ecschema-rpcinterface-common": "^5.9.2",
"@itwin/frontend-devtools": "^5.9.2",
"@itwin/ecschema-metadata": "^5.10.0-dev.22",
"@itwin/ecschema-rpcinterface-common": "^5.10.0-dev.22",
"@itwin/frontend-devtools": "^5.10.0-dev.22",
"@itwin/geo-tools-react": "workspace:*",
"@itwin/grouping-mapping-widget": "workspace:*",
"@itwin/imodel-components-react": "^5.30.0",
Expand All @@ -30,13 +30,13 @@
"@itwin/itwinui-illustrations-react": "^2.1.0",
"@itwin/itwinui-react": "3.20.1",
"@itwin/map-layers": "workspace:*",
"@itwin/map-layers-auth": "^5.9.2",
"@itwin/map-layers-formats": "^5.9.2",
"@itwin/map-layers-auth": "^5.10.0-dev.22",
"@itwin/map-layers-formats": "^5.10.0-dev.22",
"@itwin/measure-tools-react": "workspace:*",
"@itwin/one-click-lca-react": "workspace:*",
"@itwin/presentation-common": "^5.9.2",
"@itwin/presentation-common": "^5.10.0-dev.22",
"@itwin/presentation-components": "^5.13.7",
"@itwin/presentation-frontend": "^5.9.2",
"@itwin/presentation-frontend": "^5.10.0-dev.22",
"@itwin/presentation-hierarchies": "^1.7.14",
"@itwin/presentation-hierarchies-react": "^1.10.3",
"@itwin/presentation-shared": "^1.2.13",
Expand All @@ -46,7 +46,7 @@
"@itwin/tree-widget-react": "workspace:*",
"@itwin/unified-selection": "^1.7.3",
"@itwin/web-viewer-react": "^5.0.1",
"@itwin/webgl-compatibility": "^5.9.2",
"@itwin/webgl-compatibility": "^5.10.0-dev.22",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-error-boundary": "^6.1.1",
Expand Down
767 changes: 400 additions & 367 deletions apps/test-viewer/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions change/@itwin-measure-tools-react-44488275-6083-4d2e-88ae-a20c28c82ef5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Bump @itwin/core-* peer dependencies to ^5.10.0 and replace magic unit strings with generated Units.* identifiers from @itwin/core-quantity. Notably, Units.HORIZONTAL_DIRECTION.HORIZONTAL_DIR_RAD is now canonical for bearing persistence units.",
"packageName": "@itwin/measure-tools-react",
"email": "HoangNam.Le@bentley.com",
"dependentChangeType": "patch"
}
38 changes: 19 additions & 19 deletions packages/itwin/measure-tools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,42 +44,42 @@
"url": "http://www.bentley.com"
},
"peerDependencies": {
"@itwin/appui-abstract": "^5.9.2",
"@itwin/appui-abstract": "^5.10.0-dev.22",
"@itwin/appui-react": "^5.6.0",
"@itwin/components-react": "^5.6.0",
"@itwin/core-bentley": "^5.9.2",
"@itwin/core-common": "^5.9.2",
"@itwin/core-frontend": "^5.9.2",
"@itwin/core-geometry": "^5.9.2",
"@itwin/core-quantity": "^5.9.2",
"@itwin/core-bentley": "^5.10.0-dev.22",
"@itwin/core-common": "^5.10.0-dev.22",
"@itwin/core-frontend": "^5.10.0-dev.22",
"@itwin/core-geometry": "^5.10.0-dev.22",
"@itwin/core-quantity": "^5.10.0-dev.22",
"@itwin/core-react": "^5.6.0",
"@itwin/ecschema-metadata": "^5.9.2",
"@itwin/ecschema-metadata": "^5.10.0-dev.22",
"@itwin/itwinui-react": "^3.16.0",
"react": "^17.0.0 || ^18.0.0",
"react-dom": "^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@itwin/appui-abstract": "5.9.2",
"@itwin/appui-abstract": "5.10.0-dev.22",
"@itwin/appui-react": "^5.21.0",
"@itwin/build-tools": "5.9.2",
"@itwin/build-tools": "5.10.0-dev.22",
"@itwin/components-react": "^5.21.0",
"@itwin/core-bentley": "5.9.2",
"@itwin/core-common": "5.9.2",
"@itwin/core-frontend": "5.9.2",
"@itwin/core-geometry": "5.9.2",
"@itwin/core-i18n": "5.9.2",
"@itwin/core-markup": "5.9.2",
"@itwin/core-orbitgt": "5.9.2",
"@itwin/core-quantity": "5.9.2",
"@itwin/core-bentley": "5.10.0-dev.22",
"@itwin/core-common": "5.10.0-dev.22",
"@itwin/core-frontend": "5.10.0-dev.22",
"@itwin/core-geometry": "5.10.0-dev.22",
"@itwin/core-i18n": "5.10.0-dev.22",
"@itwin/core-markup": "5.10.0-dev.22",
"@itwin/core-orbitgt": "5.10.0-dev.22",
"@itwin/core-quantity": "5.10.0-dev.22",
"@itwin/core-react": "^5.21.0",
"@itwin/ecschema-metadata": "5.9.2",
"@itwin/ecschema-metadata": "5.10.0-dev.22",
"@itwin/eslint-plugin": "^4.1.1",
"@itwin/imodel-components-react": "^5.21.0",
"@itwin/itwinui-react": "^3.19.7",
"@itwin/presentation-common": "^5.4.0",
"@itwin/presentation-components": "^5.12.14",
"@itwin/presentation-frontend": "^5.4.0",
"@itwin/webgl-compatibility": "5.9.2",
"@itwin/webgl-compatibility": "5.10.0-dev.22",
"@types/chai": "^4.3.20",
"@types/chai-as-promised": "^7.1.8",
"@types/jest": "^27.5.2",
Expand Down
Loading
Loading