ez_http_tag_location → ez_http_cache_tag_location#1297
ez_http_tag_location → ez_http_cache_tag_location#1297adriendupuis wants to merge 2 commits intomasterfrom
Conversation
adamwojs
left a comment
adamwojs
left a comment
There was a problem hiding this comment.
@ezsystems/documentation-team Could you please add ez_http_cache_tag_location and other HTTP cache related function to https://doc.ibexa.co/en/latest/guide/twig_functions_reference/ ?
docs/guide/http_cache.md
Outdated
| {{ ez_http_cache_tag_location(location) }} | ||
| ``` | ||
|
|
||
| 2\. `ez_http_tag_relation_ids()` or `ez_http_tag_relation_location_ids()` |
There was a problem hiding this comment.
Likely, these functions should also have the ez_http_cache prefix
There was a problem hiding this comment.
@adamwojs
Could you please confirm that
ez_http_tag_relation_ids() and ez_http_tag_relation_location_ids()
should be updated in the docs to
ez_http_cache_tag_relation_ids() and ez_http_cache_tag_relation_location_ids()
There was a problem hiding this comment.
@vidarl ez_http_cache_tag_location doesn't exist (yet).And the goal of ezsystems/ezplatform-http-cache#143 wasn't to create it. Could it be done in another PR?
There was a problem hiding this comment.
ez_http_cache_tag_relation_ids and ez_http_cache_tag_relation_location_ids added in ezsystems/ezplatform-http-cache#143
Doc updated in 4f9b410 to have this two new Twig functions with the ez_http_cache_tag_ prefix.
We do not mention them in the docs, the policy is to list deprecations, like here: For whatever reason these deprecations have not been reported at v3.0 and this branch has already been abandoned. At this point we should simply replace the deprecated signatures with proper ones. |
|
Hi @adriendupuis , |
Hello @dabrt |
|
Bonjour @adriendupuis |
|
Those Twig function names have been updated in #1403 |
4 participants
Replace
ez_http_tag_location(kept for 2.5 BC) withez_http_cache_tag_location.